Fix for rrf documentation test using a knn retriever #120112
Merged
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>test
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Thanks for the review @john-wagster ! Made a small additional change, would appreciate a fresh look whenever you have some time! |
|
Pinging @elastic/es-docs (Team:Docs) |
benwtrent
reviewed
Jan 16, 2025
docs/reference/search/search-your-data/retrievers-examples.asciidoc
Outdated
Show resolved
Hide resolved
pmpailis
added
v8.18.0
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
retrievers-examplesdocumentation, a test was failing due to unexpected ordering of theknnsub-retriever. In this PR, we ensure that we're using aflatindexer to ensure consistent and deterministic scoring and results for the tests.Closes #119485 and #119155